RepositoryConnectionWrapper does not synchronise ParserConfig references

Description

RepositoryConnectionWrapper implementations do not pass through their ParserConfig reference to their delegate, and they also do not set their ParserConfig reference based on the delegates.

isDelegatingAdd (and not isDelegatingRemove or isDelegatingRead) is also used to determine which of the two ParserConfig objects to use or set during calls to both getParserConfig and setParserConfig, so users would need to temporarily switch the value of isDelegatingAdd to synchronise both references to point to the same ParserConfig object if they tried to do it themselves.

Given that ParserConfig references are no longer static, and by design they are to be shared as far as necessary, RepositoryConnectionWrapper should, in its constructor, either reuse the delegates ParserConfig object, or set the delegates ParserConfig object to its own object.

Environment

None

Status

Assignee

Peter Ansell

Reporter

Peter Ansell

Labels

None

Components

Fix versions

Affects versions

Priority

Major
Configure